Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remake-bindings added to bootsrap #973

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: remake-bindings added to bootsrap #973

merged 1 commit into from
Jul 5, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Jul 5, 2023 •
edited
Loading

Considering it a fix as it is part of our process

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad
fix: remake-bindings added to bootsrap
d83c57c 
Considering it a fix as it is part of our process
Maddiaa0
Maddiaa0 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im onboard

@ludamad ludamad requested a review from Maddiaa0 July 5, 2023 14:13
@ludamad ludamad force-pushed the adam/remake-bindings-in-bootstrap-sh branch from 2a9a2b5 to d83c57c Compare July 5, 2023 14:24
@ludamad ludamad merged commit 4871180 into master Jul 5, 2023
@ludamad ludamad deleted the adam/remake-bindings-in-bootstrap-sh branch July 5, 2023 14:24
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maddiaa0 Maddiaa0 Awaiting requested review from Maddiaa0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludamad @Maddiaa0