feat: Origin Tags part 3 (Memory) #9758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rumata888
force-pushed
the
is/origin_tag_part_3
branch
2 times, most recently
from
dfa79be to
ccc27ff
Compare
Rumata888
force-pushed
the
is/origin_tag_part_3
branch
from
44d3d72 to
85eec78
Compare
Rumata888
changed the title
Rumata888
commented
Nov 7, 2024
| @@ -247,7 +273,13 @@ template <typename Builder> void ram_table<Builder>::write(const field_pt& index | |||
|
|
|||
| _index_initialized[cast_index] = true; | |||
| } else { | |||
| _context->write_RAM_array(_ram_id, index_wire.normalize().get_witness_index(), value_wire.get_witness_index()); | |||
Sarkoxed
requested changes
Nov 7, 2024
| @@ -49,13 +52,19 @@ template <typename Builder> void rom_table<Builder>::initialize_table() const | |||
| context->set_ROM_element(rom_id, i, entries[i].get_witness_index()); | |||
| } | |||
|
|
|||
| // Preserve tags to restore them in the future lookups | |||
There was a problem hiding this comment.
I think you forgot to initialize the tags inside the rom_table constructor
There was a problem hiding this comment.
It's a vector, so it is default-initialized
ludamad
pushed a commit
that referenced
this pull request
Nov 11, 2024
This PR: 1. Adds Origin Tags for tracking dangerous interactions to all stdlib memory primitives 2. Expands the tests from TwinRomTable 3. Fixes a bug with the use of nonnormalized value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: