Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only increase indices if we actually find notes #9953

Open
Tracked by #9119
nventuro opened this issue Nov 13, 2024 · 0 comments
Open
Tracked by #9119

Only increase indices if we actually find notes #9953

nventuro opened this issue Nov 13, 2024 · 0 comments
Labels
C-pxe Component: PXE (Private eXecution Envrionment) team-fairies Nico's team

Comments

@nventuro
Copy link
Contributor

nventuro commented Nov 13, 2024

In #9794 we're blindly incrementing recipient tag indices as soon as we see any logs with the corresponding tag. This means a third party could spam us with bad logs with the expected tags and cause for us to incorrectly increase the tag index. Notably, said third party would need to know the tagging secret, and therefore the secret encryption key (h + ivsk) of either sender or recipient, making this attack have low likelihood.

To prevent this, we should only increase the index if we actually find a note in the log. We may never get to do this if we instead choose to e.g. implement the ideas described in https://forum.aztec.network/t/on-note-discovery-and-index-coordination/7165.

@nventuro nventuro added C-pxe Component: PXE (Private eXecution Envrionment) team-fairies Nico's team labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-pxe Component: PXE (Private eXecution Envrionment) team-fairies Nico's team
Projects
None yet
Development

No branches or pull requests

1 participant