Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid targeting honk test files when testing is disabled #125

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix: Avoid targeting honk test files when testing is disabled #125

merged 1 commit into from
Feb 9, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 7, 2023

Description

This is the first in a series of PRs to get barretenberg builds working for Noir. As I started porting things over, I was getting a crash due to using -DTESTING=OFF because the honk_test_objects target didn't exist.

(I'm not sure who to request reviews from so sorry if I added someone by mistake)

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

dbanks12
dbanks12 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. Looks good to me.

@dbanks12 dbanks12 merged commit e4a70ed into master Feb 9, 2023
@dbanks12 dbanks12 deleted the phated/honk-testing branch February 9, 2023 00:11
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@phated
fix: Avoid targeting honk test files when testing is disabled (AztecP…
c155f79 
…rotocol/barretenberg#125)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@phated
fix: Avoid targeting honk test files when testing is disabled (AztecP…
d071a04 
…rotocol/barretenberg#125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

@adr1anh adr1anh Awaiting requested review from adr1anh

@charlielye charlielye Awaiting requested review from charlielye

@codygunton codygunton Awaiting requested review from codygunton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phated @dbanks12