Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pkgconfig output for installed target #208

Merged
merged 3 commits into from
Mar 7, 2023
Merged

feat: Add pkgconfig output for installed target #208

merged 3 commits into from
Mar 7, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Mar 7, 2023

Description

Closes #203

This adds a pkg-config install target so we can provide details for consuming barretenberg via pkg-config. I also needed to fix the PROJECT_VERSION variable so we output the correct version in pkg-config file. And I added comments that @dbanks12 asked for in #185

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@phated phated requested a review from dbanks12 March 7, 2023 17:33
@phated phated changed the title Phated/pkgconfig feat: Add pkgconfig output for installed target Mar 7, 2023
@dbanks12 dbanks12 merged commit d85a365 into master Mar 7, 2023
@dbanks12 dbanks12 deleted the phated/pkgconfig branch March 7, 2023 18:22
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@phated
feat: Add pkgconfig output for installed target (AztecProtocol/barret…
85dbefb 
…enberg#208)

* feat: Add pkgconfig output for installed target

* fix: Specify version with the project function

* chore: Add documentation to install targets
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@phated
feat: Add pkgconfig output for installed target (AztecProtocol/barret…
8cfc9d1 
…enberg#208)

* feat: Add pkgconfig output for installed target

* fix: Specify version with the project function

* chore: Add documentation to install targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consumable via pkg-config
2 participants
@phated @dbanks12