Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align native library object library with wasm #238

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Mar 13, 2023

Description

When consuming bb in Noir, my tests were crashing because some symbols didn't exist in the linked barretenberg library. It seems that they come from transcript and proof_system modules.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@phated phated force-pushed the phated/include-needed-objects branch from 7e93725 to 3a2eca8 Compare March 14, 2023 15:27
@phated
Copy link
Contributor Author

phated commented Mar 14, 2023

In #232, @ludamad changed the wasm objects but not the native objects. I've updated to align them. We need to figure out a better way to handle this so it doesn't keep getting out of sync.

@phated phated changed the title fix: Include transcript and proof_system objects in library fix: Align native library object library with wasm Mar 14, 2023
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kobyhallx kobyhallx merged commit 4fa6c0d into master Mar 14, 2023
@kobyhallx kobyhallx deleted the phated/include-needed-objects branch March 14, 2023 18:49
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants