Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASM codepaths sometimes cause Illegal instruction crash #328

Open
phated opened this issue Apr 6, 2023 · 0 comments
Open

ASM codepaths sometimes cause Illegal instruction crash #328

phated opened this issue Apr 6, 2023 · 0 comments

Comments

@phated
Copy link
Contributor

phated commented Apr 6, 2023

It's pretty common in Ubuntu on GitHub Actions CI to get Illegal instruction crashes when we don't use DISABLE_ASM cmake option.

In #237, we disabled ASM when consuming BB via Nix, but the ASM code should be fixed or removed in the longer term.

Spoke with Blaine and Noir codebase has had asm and adx disabled for a while since it kept giving this illegal instruction in CI. I'm happy to merge this and open an issue to fix it later down the line

Originally posted by @kevaundray in #327 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phated