fix: Fixed the memory issue #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codygunton
approved these changes
Jun 12, 2023
| @@ -255,7 +297,7 @@ template <typename Arithmetization> class CircuitConstructorBase { | |||
| _failed = true; | |||
| set_err(msg); | |||
| } | |||
| }; | |||
| }; // namespace proof_system | |||
There was a problem hiding this comment.
This is actually the end of the class definition, not the namespace.
| @@ -291,6 +297,24 @@ std::shared_ptr<UltraHonkComposerHelper::Flavor::ProvingKey> UltraHonkComposerHe | |||
| proving_key->table_3 = poly_q_table_column_3; | |||
| proving_key->table_4 = poly_q_table_column_4; | |||
|
|
|||
| // Copy memory read/write record data into proving key. Prover needs to know which gates contain a read/write | |||
There was a problem hiding this comment.
Since #520, this happens in compute_witness, right?
| * recursive proof-specific public inputs, so we can't check the recursive proof fully in check_circuit. So we use | ||
| * this additional function to check that the recursive proof points work. | ||
| * | ||
| * @return true |
There was a problem hiding this comment.
Return documentation is funny.
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
* Fixed the memory issue * Switched recursion to use check_circuit (but still use composers) * Low-impact fix of circular dependency --------- Co-authored-by: codygunton <codygunton@gmail.com>
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
* Fixed the memory issue * Switched recursion to use check_circuit (but still use composers) * Low-impact fix of circular dependency --------- Co-authored-by: codygunton <codygunton@gmail.com>
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue we had with Ultra RAM and ROM after splitting, where check_circuit was confused by public inputs after circuit finalisation.
Also changed recursion to do the final check with check_circuit + an auxiliary function that check the recursive proof point pairing.
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.