Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update release-please.yml #651

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Aug 8, 2023

Description

When downloading the artifact, we need to use the name that we used when uploading and not the name of the file we need.

Using feat, so that we can push another release

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@kevaundray kevaundray marked this pull request as ready for review August 8, 2023 11:52
@kevaundray kevaundray changed the title chore: Update release-please.yml feat: Update release-please.yml Aug 8, 2023
@kevaundray kevaundray merged commit 2795df6 into master Aug 8, 2023
@kevaundray kevaundray deleted the kw/patch-release-please-name branch August 8, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants