Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Container post-create-command fails b/c GIT isn't installed #2

Closed
diberry opened this issue Jan 10, 2024 · 4 comments · Fixed by #16
Closed

Dev Container post-create-command fails b/c GIT isn't installed #2

diberry opened this issue Jan 10, 2024 · 4 comments · Fixed by #16

Comments

@diberry
Copy link
Contributor

diberry commented Jan 10, 2024

image

Container does open.

@pamelafox
Copy link
Contributor

Ah thats the second time I've gotten a report like this (but on a different repo). I'll ask if something happened with dev containers recently. You can delete pre-commit install from the postCreateCommand for now.

@diberry
Copy link
Contributor Author

diberry commented Jan 10, 2024

I wound up changing the dev container:

"features": 
   ...
   "ghcr.io/devcontainers/features/git:1": {},
}

And will change the postCreateCommand to:

    "postCreateCommand": "pip install -r requirements-dev.txt"

@pamelafox
Copy link
Contributor

You could also try this fix:

[ -d .git ] && pre-commit install

That's what I've added to devcontainer.json

I haven't heard back from dev containers team on what changed to cause the errors.

@pamelafox
Copy link
Contributor

What OS were you on when this happened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants