Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all pages containing chunk are displayed in PDF preview when chunk spans several pages #763

Closed
Timmate opened this issue Oct 9, 2023 · 3 comments

Comments

@Timmate
Copy link

Timmate commented Oct 9, 2023

Please provide us with the following information:

This issue is for a: (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Expected/desired behavior

Each chunk can span a few pages, but not more than 2 with the standard settings (i.e., chunk size, etc.). When a chunk is used to answer the user's question and that chunk spans two pages, both pages should be displayed in the PDF preview when clicking on the citation for that chunk. Currently, only the page where such a chunk begins is showed.

OS and Version?

Windows 10. Linux (Debian)

@pamelafox
Copy link
Collaborator

We are thinking of changing the UI to display the entire PDF with an anchor link to jump to the page, so I think that would end up addressing this issue as well.

@plasma-vision
Copy link

@pamelafox That would be a much better way to do it. Is there a branch where this feature is being worked on?

@pamelafox
Copy link
Collaborator

Ah, I made the change in #840 and merged to main on Friday, so I'll close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants