Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

few shot reversed in get_messages_from_history #851

Closed
AMusarella opened this issue Oct 24, 2023 · 1 comment · Fixed by #852
Closed

few shot reversed in get_messages_from_history #851

AMusarella opened this issue Oct 24, 2023 · 1 comment · Fixed by #852

Comments

@AMusarella
Copy link

Please provide us with the following information:

This issue is for a: (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

I noticed that the few shot messages are inserted in reverse order within the conversation, is this a desired behaviour? By not specifying the index in the append_message function, they are all inserted in the first position, reversing the list.

Expected/desired behavior

You can quickly fix this by changing the line 338 of chatreadretrieveread.py to "for shot in reversed(few_shots):" or by specifying the index in append_message


Thanks! We'll be in touch soon.

@pamelafox
Copy link
Collaborator

Thanks for catching that! I don't think that was intentional, I've sent a PR with a fix: #852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants