Skip to content

Commit 04e88e4

Browse files
author
cwanjau
committed
address comments
1 parent 8d5f1cd commit 04e88e4

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

libraries/azure-app-configuration-importer-file-source/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@azure/app-configuration-importer-file-source",
33
"author": "Microsoft Corporation",
44
"description": "A client library for importing/exporting key-values between configuration file sources and Azure App Configuration service",
5-
"version": "2.1.3-preview",
5+
"version": "2.0.0-preview",
66
"sdk-type": "client",
77
"keywords": [
88
"node",
@@ -33,7 +33,7 @@
3333
},
3434
"dependencies": {
3535
"@azure/app-configuration": "^1.9.0",
36-
"@azure/app-configuration-importer": "2.1.3-preview"
36+
"@azure/app-configuration-importer": "2.0.0-preview"
3737
},
3838
"devDependencies": {
3939
"@microsoft/api-extractor": "^7.22.2",

libraries/azure-app-configuration-importer/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@azure/app-configuration-importer",
33
"author": "Microsoft Corporation",
44
"description": "A client library for importing/exporting key-values between configuration sources and Azure App Configuration service",
5-
"version": "2.1.3-preview",
5+
"version": "2.0.0-preview",
66
"sdk-type": "client",
77
"keywords": [
88
"node",

libraries/azure-app-configuration-importer/src/appConfigurationImporter.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,8 @@ export class AppConfigurationImporter {
5050
timeout: number,
5151
strict = false,
5252
progressCallback?: (progress: ImportProgress) => unknown,
53-
importMode?: ImportMode
53+
importMode = ImportMode.IgnoreMatch
5454
): Promise<void> {
55-
if (importMode === undefined) {
56-
importMode = ImportMode.IgnoreMatch;
57-
}
58-
5955
this.validateImportMode(importMode);
6056

6157
// Generate correlation ID for operations
@@ -97,13 +93,9 @@ export class AppConfigurationImporter {
9793
public async GetConfigurationChanges(
9894
configSettingsSource: ConfigurationSettingsSource,
9995
strict = false,
100-
importMode?: ImportMode,
96+
importMode = ImportMode.IgnoreMatch,
10197
customHeadersOption?: OperationOptions
10298
): Promise<ConfigurationChanges> {
103-
if (importMode == undefined) {
104-
importMode = ImportMode.IgnoreMatch;
105-
}
106-
10799
this.validateImportMode(importMode);
108100

109101
// Generate correlation ID

0 commit comments

Comments
 (0)