Skip to content

Commit 57d4d89

Browse files
author
cwanjau
committed
address comments
1 parent 023cf51 commit 57d4d89

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

libraries/azure-app-configuration-importer/src/internal/parsers/defaultConfigurationSettingsConverter.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ class FeatureFlagConfigurationSettingsConverter implements ConfigurationSettings
195195
const dotnetSchemaFeatureFlags = this.getDotnetFmSchemaFeatureFlags(config);
196196

197197
if (dotnetSchemaFeatureFlags) {
198-
const featureManagementIndex = Constants.FeatureManagementKeyWords.indexOf(this.dotnetFmSchemaKeyWord);
198+
const featureManagementIndex: number = Constants.FeatureManagementKeyWords.indexOf(this.dotnetFmSchemaKeyWord);
199199

200200
for (const featureFlag in dotnetSchemaFeatureFlags) {
201201
if (!this.validateFeatureName(featureFlag)) {
@@ -414,7 +414,7 @@ class FeatureFlagConfigurationSettingsConverter implements ConfigurationSettings
414414
return true;
415415
}
416416

417-
private getMsFmSchemaFeatureFlags(config: object): any {
417+
private getMsFmSchemaFeatureFlags(config: object): Array<{ [key: string]: any }>{
418418
const msFeatureManagementKeyWord = Constants.FeatureManagementKeyWords[3];
419419
const featureManagementKey = msFeatureManagementKeyWord as keyof object;
420420
const featureManagementSection = config[featureManagementKey];
@@ -430,18 +430,18 @@ class FeatureFlagConfigurationSettingsConverter implements ConfigurationSettings
430430
return featureManagementSection[Constants.FeatureFlagsKeyWord];
431431
}
432432

433-
private getDotnetFmSchemaFeatureFlags(config: object): any {
433+
private getDotnetFmSchemaFeatureFlags(config: object): { [key: string]: any } | undefined {
434434
const msFeatureManagementKeyWord = Constants.FeatureManagementKeyWords[3];
435-
const featureManagementSection = config[this.dotnetFmSchemaKeyWord as keyof object];
435+
const featureManagementSection: object = config[this.dotnetFmSchemaKeyWord as keyof object];
436436

437437
if (typeof featureManagementSection !== "object") {
438438
throw new ArgumentError(`The ${this.dotnetFmSchemaKeyWord} section must be an object.`);
439439
}
440440

441441
if (this.dotnetFmSchemaKeyWord === msFeatureManagementKeyWord) { //dotnet schema might be nested within msFmSchema
442-
const { feature_flags, ...dotnetSchemaFlags } = featureManagementSection as { [key: string]: any };
443-
if (Object.keys(dotnetSchemaFlags).length > 0) {
444-
return dotnetSchemaFlags;
442+
const { feature_flags, ...dotnetSchemaFeatureFlags } = featureManagementSection as { [key: string]: any };
443+
if (Object.keys(dotnetSchemaFeatureFlags).length > 0) {
444+
return dotnetSchemaFeatureFlags;
445445
}
446446
}
447447
else {

0 commit comments

Comments
 (0)