Skip to content

Commit f6b6a41

Browse files
author
cwanjau
committed
address comments
1 parent 751e1d8 commit f6b6a41

File tree

1 file changed

+7
-7
lines changed
  • libraries/azure-app-configuration-importer/src/internal

1 file changed

+7
-7
lines changed

libraries/azure-app-configuration-importer/src/internal/utils.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,13 @@ function isFeatureFlagValueEqual(valueA: string | MsFeatureFlagValue, valueB: st
129129
let featureFlagAValue: MsFeatureFlagValue;
130130

131131
if (typeof valueA == "string") {
132-
featureFlagAValue = toFeatureFlagValue(valueA);
132+
featureFlagAValue = toMsFeatureFlagValue(valueA);
133133
}
134134
else {
135-
featureFlagAValue = valueA;
135+
featureFlagAValue = valueA as MsFeatureFlagValue;
136136
}
137137

138-
const featureFlagBValue: MsFeatureFlagValue = toFeatureFlagValue(valueB);
138+
const featureFlagBValue: MsFeatureFlagValue = toMsFeatureFlagValue(valueB);
139139

140140
if (Object.keys(featureFlagAValue).length !== Object.keys(featureFlagBValue).length) {
141141
return false;
@@ -150,7 +150,7 @@ function isFeatureFlagValueEqual(valueA: string | MsFeatureFlagValue, valueB: st
150150
isEqual(featureFlagAValue.telemetry, featureFlagBValue.telemetry);
151151
}
152152

153-
function areFeatureFlagArraysEqual<T>(arrayA: T[], arrayB: T[]): boolean {
153+
function areArrayEqual<T>(arrayA: T[], arrayB: T[]): boolean {
154154
if (arrayA.length !== arrayB.length) {
155155
return false;
156156
}
@@ -163,10 +163,10 @@ function areFeatureFlagArraysEqual<T>(arrayA: T[], arrayB: T[]): boolean {
163163
return true;
164164
}
165165

166-
const areFeatureFlagFiltersEqual = areFeatureFlagArraysEqual<FeatureFlagClientFilters>;
167-
const areFeatureFlagVariantsEqual = areFeatureFlagArraysEqual<Variant>;
166+
const areFeatureFlagFiltersEqual = areArrayEqual<FeatureFlagClientFilters>;
167+
const areFeatureFlagVariantsEqual = areArrayEqual<Variant>;
168168

169-
function toFeatureFlagValue(value: string): MsFeatureFlagValue {
169+
function toMsFeatureFlagValue(value: string): MsFeatureFlagValue {
170170
const parsedJson: any = JSON.parse(value);
171171

172172
const msFeatureFlagValue: MsFeatureFlagValue = {

0 commit comments

Comments
 (0)