Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undesired warning in pipeline output for parameter files during deployment/validate #717

Closed
bjompen opened this issue Nov 28, 2022 · 2 comments
Labels
area/powershell enhancement New feature or request

Comments

@bjompen
Copy link
Contributor

bjompen commented Nov 28, 2022

Describe the bug

Related to #504 (?)

When deploying a template alongside a parameter.json file the Azure DevOps log outputs a warning for the parameter.json.

WARNING: [13:37:00][AzOpsScope] Unable to determine type from Template or Template Parameter file: /home/vsts/work/1/s/root/root <...>/templateName.parameters.json

As this parameter file isn't even supposed to be deployed this warning clutters the output and gives bad feedback.

Suggestions

Either make this an opt in and only show this message when high verbosity or similar is set,
or
Change this to a informational message
or
Do not parse/include .parameters.json files at all in the list of files to process as they most likely aren't ment to be deployed..

Steps to reproduce

  1. Deploy a resource.bicep with a resource.parameters.json
  2. check the Azure DevOps output

Screenshots

image

@jsandquist
Copy link
Contributor

jsandquist commented Nov 28, 2022

Regarding alternative 3 there is a scenario where only the parameters file is present in git - see discussion in #677.

Somewhat related... if you deploy a resource group using an ARM template with a params file the params file is deleted by the next pull and the subsequent Validate/Push will fail.

@daltondhcp daltondhcp changed the title Bug Report Undesired warning in pipeline output for parameter files during deployment/validate Nov 30, 2022
@daltondhcp daltondhcp added enhancement New feature or request area/powershell labels Nov 30, 2022
@daltondhcp
Copy link
Contributor

Thank you for raising this. As Jan pointed out, this is currently by design as per discussion in #677. We will consider changing this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/powershell enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants