Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/res/app/session-pool #1764

Open
2 tasks done
jlinn-microsoft opened this issue Dec 17, 2024 · 6 comments · May be fixed by Azure/bicep-registry-modules#4178
Open
2 tasks done

[Module Proposal]: avm/res/app/session-pool #1764

jlinn-microsoft opened this issue Dec 17, 2024 · 6 comments · May be fixed by Azure/bicep-registry-modules#4178
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: In PR 👉 This is when an issue is due to be fixed in an open PR Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@jlinn-microsoft
Copy link

jlinn-microsoft commented Dec 17, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/app/session-pool

Module Details

Resource type: Microsoft.App/sessionPools

There is an existing containerApps module, but sessionPools is an entirely discrete resource type, and thus warrants its own module.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

jlinn-microsoft

(Optional) Secondary Module Owner's GitHub Username (handle)

hundredacres

@jlinn-microsoft jlinn-microsoft added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Dec 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Language: Bicep 💪 This is related to the Bicep IaC language label Dec 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Dec 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Jan 7, 2025
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Resource Module 📦 This is a resource module and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Jan 15, 2025
@matebarabas matebarabas changed the title [Module Proposal]: avm/res/app/session-pools [Module Proposal]: avm/res/app/session-pool Jan 15, 2025
@matebarabas
Copy link
Contributor

Hi @jlinn-microsoft,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Jan 15, 2025
@jlinn-microsoft
Copy link
Author

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Jan 15, 2025
@matebarabas
Copy link
Contributor

Hi @jlinn-microsoft,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Jan 15, 2025
@matebarabas matebarabas moved this from Proposed to In development in AVM - Module Triage Jan 15, 2025
@jlinn-microsoft
Copy link
Author

I've opened a pull request for this new module, and it is ready for review. Thanks!

@matebarabas
Copy link
Contributor

Wow, such a quick turnaround; nice work! :) Please note that apart from the code review, we'll also have to publish the related record in the Microsoft Artifact Registry (MAR), before it can be published in the Bicep Public Registry. This normally takes a couple of days. Thanks for you patience!

@matebarabas matebarabas added the Status: In PR 👉 This is when an issue is due to be fixed in an open PR label Jan 17, 2025
@matebarabas matebarabas moved this from In development to In Review in AVM - Module Triage Jan 17, 2025
@jlinn-microsoft
Copy link
Author

Cool. Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: In PR 👉 This is when an issue is due to be fixed in an open PR Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants