Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Compatible Browser check in Web SDK #418

Open
ghost opened this issue Nov 15, 2021 · 3 comments
Open

Feature Request - Compatible Browser check in Web SDK #418

ghost opened this issue Nov 15, 2021 · 3 comments
Assignees
Labels
Bug Something isn't working Calling Issue involves Calling functionality. Needs: triage 🔍

Comments

@ghost
Copy link

ghost commented Nov 15, 2021

I'm currently working on a project that is integrating the Web SDK and I'd like a reliable method for determining browser compatibility. Ideally the web SDK's would provide a compatibility API.

Current Behavior
Use an incompatible browser like Firefox

  1. User taps on button to join meeting
  2. User enters name to use during meeting
  3. User confirms entry
  4. callAgent is created by client app
  5. Fails with unsupported browser exception

Desired behavior

  1. Client SDK invokes API method
  2. If browser is compatible
    • Perform Join meeting flow
  3. Else browser is incompatible
    • Direct user to meeting alternative

Current Solution
We could use the check that the Hero example uses, treat only Firefox browser as incompatible

However, the documentation describes more than just Firefox being incompatible.

Browsing the analytics reports for our app, about a third of the reported users' browsers are "Unknown"

@ghost ghost added Bug Something isn't working Needs: triage 🔍 labels Nov 15, 2021
@eamreyes
Copy link

Subscribing as my previous account was deleted.

@davideberlein
Copy link

davideberlein commented Sep 28, 2022

We have the same problem.
The funny thing is that you recently introduced the Environment API to be able to check the browser compatibility but that API actually needs a CallClient first.
Also having some better docs on the flags of the environment API would also be helpful to determine which flag to best use (once the bug is fixed)

@akania akania self-assigned this May 4, 2023
@akania akania added the Calling Issue involves Calling functionality. label May 4, 2023
@akania
Copy link
Member

akania commented May 4, 2023

Environment API can be instantiated from CallClient instance, and creation of that one, should not be limited by any os/browser/version combination - once created, you can check if current combination is supported before creating callAgent
let me know if that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Calling Issue involves Calling functionality. Needs: triage 🔍
Projects
None yet
Development

No branches or pull requests

3 participants