-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming conventions #674
Comments
Will add naming scheme used in ESLZ to our FAQ. |
Hello, The request from my side is to add an option such as text box in which the customer can add their own name which we will take and build resource such as RG's or LAW's or AKV with the name they chose. |
Is there an estimated timeframe for this issue resolution? |
Hi @brianabrams, Are you referring to us providing the ability for naming your own resources as part of the accelerator (portal) experience or when we will update or docs and share the naming schemes used today for resources? For adding the ability to name your own resources, then we are still planning this but we are looking probably around July/August time on current planning/spring cycles. Let us know if this is a blocker to you and we can chat offline 👍 |
This comment has been minimized.
This comment has been minimized.
This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. |
hi @jtracey93, Can you please confirm if you will be implementing the CAF best practices naming conventions as stated in this article? https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-naming We would like to see some sort of resource naming convention wizard in the Accelerator in which we can define the components of the resource name. |
Hi @mattvanvuuren, We are currently reviewing the delta between what we deploy today across all our accelerators for ALZ and also the AVD one from what we name things today and the CAF naming standards that you linked above and this one https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations Once we have completed this delta analysis, we will be deciding on what the naming standards will be for ALZ and also the AVD accelerator as some of them do not make sense, like Private DNS Zones (prefixing them with When we have this decided between us internally, we will share in an issue, possibly here, for the community to review and input before then starting the efforts to implement in the tooling options we provide. However, our current thinking is that in the ALZ Accelerator (portal) experience we will not provide many options to customize the name for each resource as it is designed to be the "easy" button and fastest way to get to the target architecture. If customers want to fully customize their naming for each resource, we will advise them to use ALZ-Bicep or ALZ Terraform where this customization can be done at a more granular level. Hope this makes sense and welcome any feedback 👍 Thanks Jack |
Hi @jtracey93, we've been exploring the code, and it's been easy to set up so far in our sandbox before we deploy to production however we're having trouble renaming the resources from the default values you set to match the naming conventions we have defined inhouse. |
Hey @mdlister, It may not be July/August, but certainly still high on our list to do. However, I see you are using the ALZ Terraform module which I know does allow some renaming already today so looping in @matt-FFFFFF & @krowlandson to see if they can assist further here |
Trigger ADO Sync 1 |
Trigger ADO Sync 2 |
Hi @jtracey93 Is there any conclusion / update on the naming convention for the "Azure landing zone accelerator". I know the naming convention is really a client by client decision, but most of our clients just use the CAF recommendation, if this accelerator followed CAF it'll make this deployment so much easier, rather than editing the code / recreating the pieces we want to rename manually. And when I say follow CAF, I mean the "pip-sharepoint-prod-westus-001" recommendation from https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-naming. So in the deployment from the blueprint, here is the changes I'd recommend if it was to follow the CAF(ish): <style> </style>
|
Hey @jtracey93 Following up on this if there is any comment? Thanks! |
Ill add it to our team discussion for next week for re-triage |
Please share any news about the "naming Conventions" |
@YY-VV, what news would you be looking for? Are you currently blocked by this? Any info, helps us prioritise and triage further, currently this is on our backlog to do for the portal experience but we do not have an ETA |
Hi Jack! Good to hear it is on the backlog! Can you share any more details around your discussion? I guess all I want to know is that at some point the new portal experience will deploy following a more "CAF Friendly" naming convention? Or..? |
Hey @mundayn, Yup the intent will be to make the default naming pattern for resources deployed by the ALZ portal experience to align, where it can, to the CAF recommended abbreviations |
Is there an ETA on this long running issue or a workaround? It is a very difficult conversation to have with customers after guiding them through the CAF, agreeing to naming conventions and designing resource naming around: https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-naming to then say we cannot currently do that. |
@darrenhull We moved to the terraform module and there we are perfectly capable of customizing the names of all resources. |
Yup @darrenhull, we recommend the Bicep or Terraform implementation options as these allow naming flexibility as @cveld has shared 👍 |
@cveld We could use some documentation and examples of how to easily get to CAF recommended naming convention: RG for Management - rg-hub-mgmt-wu2-001 Right now it's about going to the source code and checking how it's done internally and how/if I can override each element. |
Hi Jack, do I understand correctly it is recommended to pre-create resource groups with CAF-compliant names so the module won't create a non-compliant name and after that set CAF-compliant suffix for resources? I am trying to deploy management resources (as per the module example) and cannot get proper names even with suffixes set in settings... Any advice/quick snip from the code showing how to get rg and resources named properly? Thank you! |
Hey for bicep you do indeed create the resource group first as shown in this example here https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/logging#powershell. In terraform you must use the advanced blocks e.g. https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/blob/main/tests/modules/settings/settings.management.tf#L50-L53 |
Jack, quick question regarding Advanced block for Terraform - is it documented anywhere? I am trying to give a proper name for -dns resource group containing private DNS links, but cannot find information how parameter name should be set. It looks like for management we can use Advanced block for "management" secrion: |
Here's a sample of this for DNS in config.yaml: advanced:
custom_settings_by_resource_type:
azurerm_resource_group:
dns:
"${default_location}":
name: "${dns_resource_group_name_cnc}" |
While I agree that aligning all names by default to the CAF pattern is a great improvement, that pattern is flawed IMHO (see below). The best approach would be to allow the customer to specify their naming pattern as a string using placeholders that are then replaced at runtime. For example:
UPDATE: I recognize that this will require taking into account max lengths and other restrictions that apply to various resource types. I have a Bicep module that will generate valid Azure resource names given a naming convention and a resource type. Something like that might need to be further developed first. My dislike with the CAF suggested convention is because of:
|
For clarity this is only for the Alz portal experience to start with. Would all of your suggestions apply there still? Also for some of your requirements I'd argue that tagging may be a better more flexible way. As departments and orgs change. And changing resource names is a no go. |
I am exploring the templates you provide. What is the naming convention you apply?
I found the following guidance as part of the cloud adoption framework documentation: https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-naming
Which suggests the following convention: Resource Type - Workload - Environment - Location - Instance
Whereas in the templates for example I find the following in the file
hubspoke-connectivity.json
:"azFwName": "[concat(parameters('topLevelManagementGroupPrefix'), '-fw-', parameters('location'))]",
Which suggests: Management group prefix - Resource Type - Location
Related: https://github.com//issues/545
The text was updated successfully, but these errors were encountered: