Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Deploy Spoke without Management VM #138

Open
ludoll-uwm opened this issue Nov 5, 2024 · 1 comment · May be fixed by #154
Open

Unable to Deploy Spoke without Management VM #138

ludoll-uwm opened this issue Nov 5, 2024 · 1 comment · May be fixed by #154
Assignees
Labels
bug Something isn't working in-progress Work on this issue is in progress; assignee required spoke An issue related to the research spoke code

Comments

@ludoll-uwm
Copy link

With the following parameter:
param researchVmsAreSessionHosts = true ;
We are able to get through the Hub deployment.

We are experiencing failures where it seems the research VMs are relying on the presence of a Hub Management VM that does not exist.
(Referenced in the main.bicep file for the Spoke)

// TODO: Split once into var and re-use var
var hubManagementVmSubscriptionId = split(hubManagementVmId, '/')[2]
var hubManagementVmResourceGroupName = split(hubManagementVmId, '/')[4]
var hubManagementVmName = split(hubManagementVmId, '/')[8]

Error Received:

Line |
83 | $DeploymentResult = New-AzDeployment @CmdLetParameters
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| 11:52:12 AM - Error: Code=InvalidTemplate; Message=Deployment template validation failed: 'The template variable 'hubManagementVmSubscriptionId' is not valid: The language expression property array index '2' is out of bounds.
Please see https://aka.ms/arm-functions for usage details.'.

@SvenAelterman SvenAelterman self-assigned this Dec 9, 2024
@SvenAelterman SvenAelterman added bug Something isn't working spoke An issue related to the research spoke code labels Dec 9, 2024
@SvenAelterman
Copy link
Collaborator

SvenAelterman commented Dec 9, 2024

Spoke deployment assumes there will always be a parseable resource ID for the management VM, even if AD join is not necessary.

(unconfirmed) Moreover, the storage account module may require the resource group for the management VM to existing in the hub subscription even if it's not needed.

  • Do not try to parse empty value.
  • When logonType in spoke is entraID, then filesIdentityType should default to AADKERB
  • Validate that when no AD domain join for the storage account is attempted, the management RG in hub sub does not need to exist.

@SvenAelterman SvenAelterman added the in-progress Work on this issue is in progress; assignee required label Dec 10, 2024
@SvenAelterman SvenAelterman linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-progress Work on this issue is in progress; assignee required spoke An issue related to the research spoke code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants