Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat values sent have same sourceTimestamp and serverTimestamp as LKV #2049

Closed
marcschier opened this issue Sep 7, 2023 · 2 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@marcschier
Copy link
Collaborator

In 2.8 heartbeat values had sourceTimestamp and serverTimestamp different from the LKV allowing counting distinct values. This issue is to create backwards compatibility with 2.8 by faking timestamp to be different than LKV.

@marcschier marcschier added the bug Something isn't working label Sep 7, 2023
@marcschier marcschier added this to the 2.9.2 milestone Sep 7, 2023
@marcschier
Copy link
Collaborator Author

To count distinct values you can use "--fm=True" or use the Timestamp of the dataset message which will have a distinct value if "--mts=CreatedTimeUtc" is used (2.9.2) forward. Changing source timestamp or server timestamp is wrong as it implies these were provided by the underlying OPC Server this way (there is no heartbeat indicator). While heartbeat is sent the value could be different but not yet sampled.

@marcschier marcschier closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
@marcschier marcschier reopened this Sep 11, 2023
@marcschier
Copy link
Collaborator Author

Added new --hbb=WatchdogLKVWithUpdatedTimestamps which tries to mimic 2.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant