PINS Upstream Tracking for MVP

[bocon13]

This issue tracks the status of the initial PINS contributions to upstream SONiC.

HLDs

The following HLDs describe the PINS features and enhancements to SONiC. The main HLD provides the bigger picture and refers to the supplementary HLDs for each specific feature.

PR Title	PR #	Owner	Shepherd	Comments
PINS Main HLD		@bhagatyj, @bocon13	@lguohan	Community Review Complete
P4RT App HLD		@rhalstea	@qiluo-msft	Community Review Complete
P4 Orchagent HLD		@mint570	@prsunny	Community Review Complete
P4 APPL DB Schema HLD		@kishanps	@prsunny	Community Review Complete
SAI P4 Program HLD		@smolkaj	@abdosi	Community Review Complete
APPL State DB and Response Path		@mint570	@shi-su	Community Review Complete
P4RT Packet IO		@kishanps	@prsunny	Community Review Complete
P4 Extensions HLD		@ravi861	@abdosi	Revisiting design after community comments

Code Contributions

Repo	PR Title	PR #	Comments
swss-common	Update database defintions
swss-common	Update database defintions		Revises changes made during review of sonic-net/sonic-swss-common#536
swss-common	Add batch ops and StatusCode
buildimage	Add gmock for swss-common tests
swss-common	Add ACL Schema
swss-common	Add Bazel support
swss	Add response publisher
swss	Add P4Orch
swss	Integrate P4Orch into orchagent		Depends on sonic-net/sonic-swss#1997
sonic-pins	New repo containing P4RT application and SAI P4 program
buildimage	Add APPL_STATE_DB and response path log rotation
buildimage	Add P4RT container: submodules and build files

[kishanps]

@bocon13 Can you pls add the Packet IO link (https://github.com/Azure/SONiC/pull/850/files)

[smolkaj]

@bocon13 SAI P4 Program HLD: #852

[mint570]

Some suggestion on code contributions (just suggestion, no strong opinion):

swss-common:

• We might want to remove component state helper
• All the #define can go into a single pr
• Bazel support and ConsumerNotifier can go into the same pr as the interfaces pr

swss:

• cfgmgr change can go into the response publisher pr
• request parser change can go into the vrf response path pr
• ports orch change can go into the p4orch pr

[StephenWangGoogle]

We should move hash orch related item out of MVP

[bocon13]

• We might want to remove component state helper

Only needed for critical state. Then in users (p4rt and swss) of the class, just throw an exception and exit for now

[zhangyanzhao]

@bocon13 would you please update the HLD status since the community review is completed. Also please help to add the code PR info, so that community can review.
Thanks.

[smolkaj]

Are we planning to merge the HLDs?