Layer 2 forwarding enhancements HLD #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documents decribes the functional spec and high level design for Layer 2 Forwarding Enhancements.
|
|
anilkpandey
changed the title
Changed FDB flush mechanism from individual FDB entry delete to Bulk flush in hardware.
Updated to exclude bridge_port_id in Orchagent FDB data structure as it is not needed for bulk flush. We only need the FDB type.
some minor corrections.
|
Could you also help to fix CLI "show mac" takes too much time to display mac entries, e.g. It will take more than 30+ mins to display 32K entries output? Thanks! Wilson @loshihyu |
|
Hi Wilson,
We are able to bring this time down significantly. We will share the fix
with community.
Thanks.
Anil
…On Tue, May 21, 2019 at 1:31 PM Chain-Wu Lee ***@***.***> wrote:
Could you also help to fix CLI "show mac" takes too much time to display
mac entries, e.g. It will take more than 30+ mins to display 32K entries
output? Thanks!
Wilson
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#379>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALLPOUJDQ6WFRHBQSM5YQO3PWRLY3ANCNFSM4HLWJRCQ>
.
|
|
That's great! Thanks Anil! Wilson |
1. Added per port per VLAN fdb clear option. 2. Listed all the SAI attributes being used. 3. Added -w option in VLAN Range commands to indicate logging of warning messages.
madhupalu
reviewed
Jun 7, 2019
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
stcheng
suggested changes
Jun 12, 2019
Done |
stcheng
approved these changes
Jul 10, 2019
qiluo-msft
reviewed
Jul 11, 2019
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Outdated
Show resolved
Hide resolved
keboliu
reviewed
Jul 12, 2019
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Outdated
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md
Show resolved
Hide resolved
Updated default FDB aging time.
qiluo-msft
approved these changes
Jul 15, 2019
prsunny
approved these changes
Jul 15, 2019
|
@keboliu , @madhupalu , can you review/approve this?. Looks like all the open comments are addressed. |
keboliu
approved these changes
Jul 17, 2019
rajendra-dendukuri
pushed a commit
to rajendra-dendukuri/SONiC
that referenced
this pull request
Jul 29, 2019
* Layer 2 Forwarding Enhancements FDS The documents decribes the functional spec and high level design for Layer 2 Forwarding Enhancements. * Layer 2 Forwarding Enhancements HLD * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update .DS_Store * Update .DS_Store * Updated to change FDB flush as bulk flush in hardware Changed FDB flush mechanism from individual FDB entry delete to Bulk flush in hardware. * exclude bridge_port_id in fdb data structure Updated to exclude bridge_port_id in Orchagent FDB data structure as it is not needed for bulk flush. We only need the FDB type. * exclude bridge_port_id in fdb data structure * Update SONiC Layer 2 Forwarding Enhancements HLD.md some minor corrections. * Updated with inputs from community review 1. Added per port per VLAN fdb clear option. 2. Listed all the SAI attributes being used. 3. Added -w option in VLAN Range commands to indicate logging of warning messages. * remove .DS_Store * Update SONiC Layer 2 Forwarding Enhancements HLD.md Updated default FDB aging time.
|
Hi Anil, Are there any plans to write ansible or pytest scripts to test those enhancements. @anilkpandey Thanks. |
|
Hi William, pytest scripts are added as part of the following PR: |
|
Hi Anil, It seems you have added some VS tests to test this enhancements. I also want to know if there are any plans to write test cases for this enhancements in sonic-mgmt Thanks. |
|
No, only VS pytest. |
|
Thanks Anil! I see. william-zx |
wendani
reviewed
Sep 21, 2020
|
|
||
|
|
||
| **Changes for Static FDB configuration.** | ||
| New CLI will be added for configuring Static FDB entry. It will be set in the FDB_TABLE in CONFIG_DB. Vlanmgr will handle the CONIG_DB changes, do necessary validations and then populate in APP_DB. FdbOrch already has all the necessary handling for Static FDB changes from APP_DB. |
There was a problem hiding this comment.
I am curious When a static FDB entry is removed from CLI, will SAI notify a SAI_FDB_EVENT_AGED to orchagent?
From images/staticMacConfig.jpg, even if such an event is present, orchagent will ignore it
There was a problem hiding this comment.
yes, SAI_FDB_EVENT_AGED will be received and it will be ignored at orchagent because the fdb entry does not exist anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document provides high level design for enhancements in SONiC layer 2 forwarding for FDB flush, MAC move, FDB aging time configuration, Static FDB configuration and VLAN Range configuration.
PRs:
sonic-net/sonic-sairedis#510
sonic-net/sonic-swss-common#303
sonic-net/sonic-utilities#529
sonic-net/sonic-swss#1716