-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAA improvements #583
Merged
renukamanavalan
merged 9 commits into
sonic-net:master
from
martin-belanger:aaa_improvements
Oct 5, 2020
Merged
AAA improvements #583
renukamanavalan
merged 9 commits into
sonic-net:master
from
martin-belanger:aaa_improvements
Oct 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-aviz
reviewed
Apr 10, 2020
renukamanavalan
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Martin. A very good doc.
Can this be merged? I don't see anymore unresolved comments. |
…n cannot work with this server.
@renukamanavalan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am the main AAA developer at Dell where I implemented support for RADIUS and TACACS+ authentication, authorization, and accounting. I wrote the PAM and NSS modules for Dell's AAA.
I found a few gaps in SONiC's current AAA implementation. The document I'm submitting in this pull request describes what I found and suggests a few improvements to fill these gaps.