Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chassis] Add HLD for fabric port handling in chassis #668

Merged
merged 11 commits into from
Mar 3, 2021

Conversation

eswaranb
Copy link
Contributor

This is a companion HLD for the other chassis HLDs - pulls/622 and pulls/639.

@ghost
Copy link

ghost commented Aug 28, 2020

CLA assistant check
All CLA requirements met.

@minionatwork
Copy link
Contributor

As we discussed on the review meeting, Is the direction to go Fabric ports as yet another ports and PortSyncD will manage it for fetching counters, and some show command to work?.

@eswaranb
Copy link
Contributor Author

As we discussed on the review meeting, Is the direction to go Fabric ports as yet another ports and PortSyncD will manage it for fetching counters, and some show command to work?.

We looked into this some more and concluded that we cannot use portsyncd for fabric ports. This is because

  1. Fabric ports don't have any hostifs. This means portsyncd cannot learn the port state via NETLINK messages like it does for front panel ports.
  2. All fabric ports are enabled at startup by SAI. There is no configuration necessary for them at this point.

With that said, we can use FlexCounters to collect the counters for the queues that are mapped to the fabric ports. We are in the process of verifying this. Arista team will update this doc as soon as we can.

3 : 0 2 0 0 193
```

### 2.7.1 Fabric Status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there can be many fabric links in the chassis, may be even more useful if there is a CLI to only display the links/fabric ports that have errors. Eg.. "show fabric counters errors"

@anshuv-mfst
Copy link
Collaborator

Please add @minionatwork and Srikanth to the reviewers.


PORT RxCells TxCells Crc Fec Corrected
-------------------------------------------------------------------------
0 : 71660578 2 0 0 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can port specified with bandwidth information and current utilization ?.

Copy link

@ngoc-do ngoc-do Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are talking about fabric port data rates?

We can create another cli command showing current data rates of fabric ports on an asic.

show -n asicX fabric counters rates --period Y

Output could look like:

AsicX
Fabric port | InMbps | MaxInMbps | %InMbps | OutMbps | MaxOutMbps | %OutMbps
0
1
2
...

MaxInMbps typically gets from serdes link speed (e.g., 50 Khz).

@rlhui rlhui merged commit 803b89e into sonic-net:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants