-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONiC CLI Auto-generation tool HLD #780
SONiC CLI Auto-generation tool HLD #780
Conversation
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@praveen-li thanks for your comments, but I can't see to which line in the HLD your comments are related? |
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Could you please take a look at the |
I made real examples for some auto-generation rules, could you please check? |
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@venkatmahalingam and @praveen-li thanks for the comments. |
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@venkatmahalingam and @praveen-li as the feature is now ready for review appreciate if you can check comments handling and approve the HLD as well. |
@praveen-li could you please also take a look at the implementation PR's (you can find them in this PR description)? |
@praveen-li appreciate your feedback |
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx, would you please confirm the code PRs for this feature are the two PRs listed above? |
Yes it is. |
Signed-off-by: Vadym Hlushko vadymh@nvidia.com
The high-level design document for the SONiC CLI Auto-generation tool.