Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONiC CLI Auto-generation tool HLD #780

Merged

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Apr 21, 2021

PR title state context
[sonic-cli-gen] first phase implementation of the SONiC CLI Auto-generation tool GitHub issue/pull request detail GitHub pull request check contexts
[sonic-package-manager] support sonic-cli-gen and packages with YANG model GitHub issue/pull request detail GitHub pull request check contexts

Signed-off-by: Vadym Hlushko vadymh@nvidia.com
The high-level design document for the SONiC CLI Auto-generation tool.

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@anshuv-mfst
Copy link
Collaborator

@prsunny @lguohan - could you please take a look, thanks.

@vadymhlushko-mlnx
Copy link
Contributor Author

@praveen-li thanks for your comments, but I can't see to which line in the HLD your comments are related?

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Copy link
Contributor Author

https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-interface.yang

How does the auto-generation of CLI config/show commands would look like for the above yang when we have a table container with two lists? please provide some examples for clarity.

Could you please take a look at the Open questions section and give your feedback?

@vadymhlushko-mlnx
Copy link
Contributor Author

vadymhlushko-mlnx commented May 6, 2021

If possible we can put one real example.

I made real examples for some auto-generation rules, could you please check?
Also could you please take a look at the Open questions section and give your feedback?

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@liat-grozovik
Copy link
Collaborator

@venkatmahalingam and @praveen-li thanks for the comments.
Could you please review the update HLD? we would like to upstream the code aligned with it in the next 1-2 weeks so HLD should be closed before that.

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx vadymhlushko-mlnx changed the title SONiC CLI Auto-generation HLD SONiC CLI Auto-generation tool HLD Jun 2, 2021
@liat-grozovik
Copy link
Collaborator

@venkatmahalingam and @praveen-li as the feature is now ready for review appreciate if you can check comments handling and approve the HLD as well.

@vadymhlushko-mlnx
Copy link
Contributor Author

@praveen-li could you please also take a look at the implementation PR's (you can find them in this PR description)?

@praveen-li
Copy link

praveen-li commented Jun 8, 2021 via email

@liat-grozovik
Copy link
Collaborator

@praveen-li appreciate your feedback

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@renukamanavalan renukamanavalan merged commit 898d58f into sonic-net:master Jun 28, 2021
@rlhui
Copy link
Contributor

rlhui commented Nov 16, 2021

@vadymhlushko-mlnx, would you please confirm the code PRs for this feature are the two PRs listed above?

@liat-grozovik
Copy link
Collaborator

@vadymhlushko-mlnx, would you please confirm the code PRs for this feature are the two PRs listed above?

Yes it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants