Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Generic manifest interface #2298

Closed
jackfrancis opened this issue Feb 16, 2018 · 5 comments
Closed

Generic manifest interface #2298

jackfrancis opened this issue Feb 16, 2018 · 5 comments

Comments

@jackfrancis
Copy link
Member

The use-case for this is evolving the static audit policy, implemented here:

#2189

What we want is a general "manifest" data model that we implement as a JSON object in the api model that allows custom configuration. Design TBD

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm) Kubernetes

@pidah
Copy link
Contributor

pidah commented Feb 17, 2018

just as a suggestion/middleground, would it be useful to have an option to override the audit policy file. For example we have the acs-engine config file as:

      "kubernetesConfig": {
        "networkPolicy": "calico",
        "enableRbac": true,
        "overrideAuditPolicy": {
          "url":  "https://raw.githubusercontent.com/kubernetes/website/master/docs/tasks/debug-application-cluster/audit-policy.yaml"},
        "apiServerConfig": {
          "--admission-control":  "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,ResourceQuota,AlwaysPullImages"
                  }
      }  

We can implement a generic provider that pulls these files from github (or other sources) during acs-engine deploy time. This might be useful for overriding other files like podsecuritypolicy files, encryption-config file etc or perhaps extend the scope to make it easier to place any custom file on the master/node instances. Any thoughts ? @jackfrancis @lachie83 @brendanburns @feiskyer

@pidah
Copy link
Contributor

pidah commented Sep 14, 2018

@jackfrancis hi, following up my comment in February, I just want to find out if there is a way now to override yaml files applied on a cluster e.g Pod Security Policy yaml ? Thanks 😇

@jackfrancis
Copy link
Member Author

@pidah You can do this as of last week using one of the pre-existing addons.

See here:

#3840

@pidah
Copy link
Contributor

pidah commented Sep 18, 2018

@jackfrancis super ! Thanks 👍🏿

@stale
Copy link

stale bot commented Mar 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. Note that acs-engine is deprecated--see https://github.com/Azure/aks-engine instead.

@stale stale bot added the stale label Mar 9, 2019
@stale stale bot closed this as completed Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants