Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: unknown ostype when getting an index should probably create an error #2681

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

paulgmiller
Copy link
Member

@paulgmiller paulgmiller commented Feb 4, 2020

Reason for Change:
Unknown ostype when getting an index should probably create an error
Today it just returns zero. Not sure if this is a real problem but popped up in our unittests that consume this package.

Issue Fixed:

Can create an issue but my face was already in the code :)

Requirements:

Notes:

Unknown ostype when getting an index should probably creaet an error
Today it just returns zero
@welcome
Copy link

welcome bot commented Feb 4, 2020

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@acs-bot acs-bot added the size/XS label Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #2681 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2681      +/-   ##
==========================================
+ Coverage   71.82%   71.82%   +<.01%     
==========================================
  Files         134      134              
  Lines       25099    25101       +2     
==========================================
+ Hits        18028    18030       +2     
  Misses       6015     6015              
  Partials     1056     1056

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @paulgmiller

@acs-bot acs-bot added the lgtm label Feb 5, 2020
@jackfrancis jackfrancis merged commit fb5e25b into Azure:master Feb 5, 2020
@welcome
Copy link

welcome bot commented Feb 5, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@acs-bot
Copy link

acs-bot commented Feb 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, paulgmiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants