docs: proposal for Azure locations + SKUs automation #2694
Conversation
|
|
||
| ## Non-goals | ||
|
|
||
| ## Proposal: scriptable aks-engine commands |
There was a problem hiding this comment.
I love that this proposal also standardizes the way we deliver this information to users.
|
|
||
| - Requires significant refactoring and implementation effort | ||
| - Making API calls during `aks-engine generate` may be unwanted behavior | ||
| - Somewhat slower and less reliable than using the data in code |
There was a problem hiding this comment.
I agree that the most concrete downside is absorbing runtime API flakes for all aks-engine ARM operations. Removing that contingency is worth the additional "staleness" of the consts that we statically maintain in code, especially if we reduce the stale time by automating much of the process of updating those static consts.
| ### Example SKUs output | ||
|
|
||
| ```shell | ||
| $ aks-engine get-skus -o human |
|
|
||
| ## Proposal: scriptable aks-engine commands | ||
|
|
||
| New developer-only commands in the `aks-engine` binary generate the necessary Go source code. The commands replace the existing python script and extend it to cover the accelerated networking capability list. |
There was a problem hiding this comment.
Would it make sense to take an approach like our e2e tests and wrap that in a make target instead of a new command?
If we do that it might be easier to periodically run the job in a devops pipeline or jenkins job to get a signal of when we need to perform updates.
There was a problem hiding this comment.
That signal could be that there were diffs between the checked in generated files and newly generated files.
There was a problem hiding this comment.
Yes, the presence of a diff in the code should be considered the signal that we need a PR. I forgot to put this explicitly in the doc, but 👍.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Proposes a solution for some AKS Engine data structures needing to be updated.
Issue Fixed:
See #1894
Requirements:
Notes: