Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: apiserver broken due to incorrect kms cachesize setting #2769

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

andyzhangx
Copy link
Contributor

@andyzhangx andyzhangx commented Feb 24, 2020

Reason for Change:

fix: apiserver broken due to incorrect kms cachesize
When enabling KMS feature on aks-engine, apiserver could not start up due to incorrect kms cachesize

original error is like following:

I0222 14:21:26.635590       1 services.go:51] Setting service IP to "10.0.0.1" (read-write).
I0222 14:21:26.635604       1 server.go:596] external host was not specified, using 10.255.255.5
I0222 14:21:26.635609       1 server.go:639] Initializing cache sizes based on 0MB limit
I0222 14:21:26.635886       1 server.go:150] Version: v1.18.0-alpha.5
Error: error while parsing encryption provider configuration file "/etc/kubernetes/encryption-config.yaml": error while parsing file: resources[0].providers[0].kms.cachesize: Invalid value: 0: cachesize should be a positive value, or negative to disable
Usage:

Issue Fixed:

Requirements:

Notes:

@andyzhangx andyzhangx requested a review from ritazh February 24, 2020 05:41
@andyzhangx andyzhangx changed the title fix: apiserver broken due to incorrect kms cachesize fix: apiserver broken due to incorrect kms cachesize setting Feb 24, 2020
@andyzhangx
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2769 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2769   +/-   ##
=======================================
  Coverage   72.35%   72.35%           
=======================================
  Files         137      137           
  Lines       25341    25341           
=======================================
  Hits        18335    18335           
  Misses       5949     5949           
  Partials     1057     1057

@jackfrancis
Copy link
Member

@ritazh could you code review this?

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acs-bot
Copy link

acs-bot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit fa8c367 into Azure:master Feb 24, 2020
@andyzhangx
Copy link
Contributor Author

cc @sauryadas

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants