Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: components works with Azure Stack #2775

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR makes the new components interface work w/ Azure Stack. There is nothing Azure Stack-specific about how it defines the KubernetesImageBase configuration, and this change removes the assumption that Azure Stack uses the AzureCloudSpecEnvMap map to define it.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2775 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2775      +/-   ##
==========================================
- Coverage   72.35%   72.35%   -0.01%     
==========================================
  Files         137      137              
  Lines       25341    25339       -2     
==========================================
- Hits        18335    18333       -2     
  Misses       5949     5949              
  Partials     1057     1057

@jadarsie
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 31823c4 into Azure:master Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants