This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: update yaml.v2 and golangci-lint for go 1.14 compatibility #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2824 +/- ##
=======================================
Coverage 72.44% 72.44%
=======================================
Files 140 140
Lines 25562 25562
=======================================
Hits 18518 18518
Misses 5976 5976
Partials 1068 1068 |
|
Developers may need to do |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Updates
make buildand friends for the go 1.14 toolchain.Note that we're still using go 1.13.8 in CI for now, so this should work with both versions. I have tested locally with go 1.14.
Issue Fixed:
Fixes #2812
Requirements:
Notes: