This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: don't re-run provision.sh if already called. #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still trying to gigure out what actually changes here that causes us to rerun CSE's on model update before reimage. Nathan Kutcha says any change under settings/protected setting will trigger it (we don't set timestamp or forceupdate so it's not that) Dumping templates at create and upgrade code paths to see if any of the arm variables change (provisionScriptParametersCommon, provisionScriptParametersMaster)
|
Still investigating here but creating a PR as it was easier and more informative than an issue maybe? |
jackfrancis
changed the title
jackfrancis
reviewed
Mar 5, 2020
Not sure who inherits this but better to block it out?
paulgmiller
changed the title
jackfrancis
reviewed
Mar 10, 2020
jackfrancis
changed the title
|
@paulgmiller make generate and commit generated code to appease UT check |
Codecov Report
@@ Coverage Diff @@
## master #2843 +/- ##
==========================================
- Coverage 72.47% 72.46% -0.01%
==========================================
Files 140 140
Lines 25589 25675 +86
==========================================
+ Hits 18545 18606 +61
- Misses 5976 5993 +17
- Partials 1068 1076 +8 |
|
don't suppose there's unittests for the bash script I can improve :) |
|
@paulgmiller feel free to add some! :) j/k We do use shellcheck, so there's something |
|
Thanks @paulgmiller! |
paulgmiller
added a commit
to paulgmiller/aks-engine
that referenced
this pull request
Mar 27, 2020
serbrech
pushed a commit
that referenced
this pull request
Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because commandToExecute changes with every upgrade (since the kubernetes version env variable changes) CSE are run when AKS tried to do an instance upgrade then reimage (which vmss is recommending as preferred over creating and deleting repeatedly).
Rerunning the CSE's seems to hit a file watch timeout maybe 1:8 or 1:16 times. I have not found the file responsible just the error code.
However it seems like the CSE's were not made to be idempotent and maybe shoudl just abort if they've already run to completion. So maybe it's a good idea in general to check the provision.complete sentinal file that already gets emited at the end of the script?
Reason for Change:
Issue Fixed:
Requirements:
Notes: