-
Notifications
You must be signed in to change notification settings - Fork 519
Conversation
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #2905 +/- ##
==========================================
- Coverage 72.49% 72.48% -0.02%
==========================================
Files 141 141
Lines 25847 25863 +16
==========================================
+ Hits 18739 18746 +7
- Misses 6021 6027 +6
- Partials 1087 1090 +3
Continue to review full report at Codecov.
|
Thanks @andyzhangx! There appear to be missing implementations for both agentPoolProfile and masterProfile. Here's a recent PR for reference that added a property to both master and agent type definitions: We want to make sure we similarly update both configuration objects for this changes as well, on these vectors:
|
@jackfrancis PTAL |
feat: address UltraSSD comments
@jackfrancis PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @andyzhangx
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yangl900 @xuto2 @palma21 FYI UltraSSD support has landed in AKS Engine w/ functional E2E test coverage @ritazh @craiglpeters FYI |
thanks for the code review, this feature is required by some customers, next we need to integrate into AKS. |
Reason for Change:
This PR adds UltraSSD support for both AgentPool and master node, details about UltraSSD
Issue Fixed:
Requirements:
Notes:
cc @kkmsft