Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: fix ginkgo failFast #3738

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

jadarsie
Copy link
Member

@jadarsie jadarsie commented Aug 21, 2020

Reason for Change:

The way the E2E runner was building the ginkgo command was not gracefully handling empty parameters (in this case failFast)

Related to #3660

Requirements:

Notes:

mboersma
mboersma previously approved these changes Aug 24, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis
Copy link
Member

@jadarsie @haofan-ms thanks for root causing this!

Let's go ahead and change this default to false so we can start running the complete set of tests on all test runs by default:

https://github.com/Azure/aks-engine/blob/master/test/e2e/config/config.go#L50

(Doing so in this PR will also act as a simple smoke test for this fix.)

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #3738 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3738   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         147      147           
  Lines       25322    25322           
=======================================
  Hits        18529    18529           
  Misses       5655     5655           
  Partials     1138     1138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6315a93...7957315. Read the comment docs.

@jadarsie jadarsie requested a review from jackfrancis August 24, 2020 20:16
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Aug 24, 2020
@jackfrancis jackfrancis merged commit c917d11 into Azure:master Aug 24, 2020
@acs-bot
Copy link

acs-bot commented Aug 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jackfrancis pushed a commit that referenced this pull request Aug 25, 2020
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants