-
Notifications
You must be signed in to change notification settings - Fork 520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@jadarsie @haofan-ms thanks for root causing this! Let's go ahead and change this default to https://github.com/Azure/aks-engine/blob/master/test/e2e/config/config.go#L50 (Doing so in this PR will also act as a simple smoke test for this fix.) |
Codecov Report
@@ Coverage Diff @@
## master #3738 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 147 147
Lines 25322 25322
=======================================
Hits 18529 18529
Misses 5655 5655
Partials 1138 1138 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, jadarsie, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
The way the E2E runner was building the
ginkgo
command was not gracefully handling empty parameters (in this casefailFast
)Related to #3660
Requirements:
Notes: