-
Notifications
You must be signed in to change notification settings - Fork 519
Conversation
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - |
Thanks @thatmattlong! Does this version of Azure CNI include transparent mode by default in the released tarball? |
@sozercan can you please upload the artiifacts to acs mirror? |
Hey @jackfrancis , yes this version is transparent by default |
sed -i 's#"mode":"bridge"#"mode":"transparent"#g' $CNI_CONFIG_DIR/10-azure.conflist | ||
elif [[ "${NETWORK_POLICY}" == "" || "${NETWORK_POLICY}" == "none" ]] && [[ "${NETWORK_MODE}" == "transparent" ]]; then | ||
sed -i 's#"mode":"bridge"#"mode":"transparent"#g' $CNI_CONFIG_DIR/10-azure.conflist | ||
if [[ "${NETWORK_MODE}" == "bridge" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuto2 @paulgmiller FYI, I'm inverting the CSE "NetworkMode" logic here to account for the fact that 1.2.0 of Azure CNI is transparent by default in the extracted tarball.
thanks! I've added some changes to the bootstrap scripts to accommodate that |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
@thatmattlong artifacts should be uploaded now |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #4058 +/- ##
=======================================
Coverage 73.23% 73.23%
=======================================
Files 135 135
Lines 20640 20640
=======================================
Hits 15115 15115
Misses 4549 4549
Partials 976 976
Continue to review full report at Codecov.
|
@sozercan this from ~45 mins ago"
Should I retry? |
@jackfrancis if you try again, it might just magically work :) (there was a path issue - fixed now) |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Congrats on merging your first pull request! 🎉🎉🎉 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, thatmattlong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: