Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: validate VHD availability before upgrade/scale on Azure Stack Hub #4062

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

jadarsie
Copy link
Member

Reason for Change:

Completing work started in #2342. This change blocks an upgrade operation if any required OS image is not available in the target Azure Stack Hub PIR (Platform Image Repository).

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #4062 (aee236e) into master (7fdbef0) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4062      +/-   ##
==========================================
- Coverage   73.25%   73.19%   -0.07%     
==========================================
  Files         135      135              
  Lines       20542    20558      +16     
==========================================
- Hits        15048    15047       -1     
- Misses       4521     4539      +18     
+ Partials      973      972       -1     
Impacted Files Coverage Δ
cmd/deploy.go 60.79% <0.00%> (-0.34%) ⬇️
cmd/scale.go 12.56% <0.00%> (-0.29%) ⬇️
cmd/upgrade.go 37.75% <0.00%> (-1.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fdbef0...aee236e. Read the comment docs.

@jadarsie jadarsie changed the title chore: validate VHD availability before upgrade on Azure Stack Hub chore: validate VHD availability before upgrade/scale on Azure Stack Hub Nov 30, 2020
@jadarsie jadarsie requested a review from jackfrancis November 30, 2020 18:00
cmd/scale.go Outdated Show resolved Hide resolved
cmd/upgrade.go Outdated Show resolved Hide resolved
@jadarsie jadarsie requested a review from jackfrancis November 30, 2020 18:23
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jadarsie jadarsie merged commit f66817c into Azure:master Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants