Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: add new Azure VM SKUs, brazilsoutheast, westus3 regions #4224

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR updates Azure consts, enabling more recent VM SKUs.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

@penggu, can you review these changes? Do these include the required VM SKUs you need?

@jackfrancis jackfrancis changed the title chore: update Azure consts chore: add new Azure VM SKUs, brazilsoutheast, westus3 regions Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #4224 (49f3c53) into master (908ad43) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4224   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files         135      135           
  Lines       20849    20851    +2     
=======================================
+ Hits        15296    15298    +2     
  Misses       4576     4576           
  Partials      977      977           
Impacted Files Coverage Δ
pkg/helpers/azure_locations.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908ad43...49f3c53. Read the comment docs.

@jadarsie
Copy link
Member

jadarsie commented Feb 3, 2021

/lgtm

giving @penggu some time to chime in

@acs-bot
Copy link

acs-bot commented Feb 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jadarsie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 5a68771 into Azure:master Feb 3, 2021
@jackfrancis jackfrancis deleted the chore-azure-consts branch February 3, 2021 23:47
@penggu
Copy link
Contributor

penggu commented Feb 4, 2021

@penggu, can you review these changes? Do these include the required VM SKUs you need?

@jackfrancis Yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants