Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: rotate-certs fails faster if invalid ssh params #4252

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

jadarsie
Copy link
Member

Reason for Change:

Addressing some aks-engine rotate-certs feedback

  • document azure-env parameter
  • fail faster if --ssh-host or --linux-ssh-private-key are invalid
  • delete previous doc page
  • more explicit stdout messages

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

Notes:

@jadarsie jadarsie requested a review from jackfrancis February 10, 2021 18:31
@@ -1,60 +0,0 @@
# Cluster certificate rotation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we deleting these docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has duplicated/stale information, I pushed another one with my previous PR.

https://github.com/Azure/aks-engine/blob/master/docs/topics/rotate-certs.md

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #4252 (e0161ed) into master (9924649) will decrease coverage by 0.01%.
The diff coverage is 59.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4252      +/-   ##
==========================================
- Coverage   72.08%   72.07%   -0.02%     
==========================================
  Files         141      141              
  Lines       21712    21719       +7     
==========================================
+ Hits        15652    15653       +1     
- Misses       5103     5111       +8     
+ Partials      957      955       -2     
Impacted Files Coverage Δ
cmd/rotate_certs.go 11.03% <0.00%> (-0.60%) ⬇️
pkg/api/vlabs/validate.go 80.90% <90.47%> (+0.17%) ⬆️
pkg/api/addons.go 98.10% <100.00%> (ø)
pkg/api/convertertoapi.go 94.02% <100.00%> (-0.04%) ⬇️
pkg/api/defaults.go 93.45% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b865c...e0161ed. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jadarsie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants