Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: remove duplicate labels for cilium-operator #4260

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

mattstam
Copy link
Contributor

Reason for Change:

Fixes duplicate "labels" annotation inside the cilium.yaml addon file

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

Although this addon may not be used anymore, I was experimenting around with this setup and noticed problems using it due to duplicate label annotation.

@welcome
Copy link

welcome bot commented Feb 11, 2021

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@mattstam mattstam force-pushed the matt-stam/cilium-typo branch 2 times, most recently from 5849242 to a2c2da9 Compare February 11, 2021 20:38
@mattstam mattstam force-pushed the matt-stam/cilium-typo branch from a2c2da9 to 20e8538 Compare February 11, 2021 20:38
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thx @matt-stam

btw I'm not sure if this unmaintained cilium spec actually works anymore :/

@jackfrancis jackfrancis merged commit e75cc99 into Azure:master Feb 11, 2021
@welcome
Copy link

welcome bot commented Feb 11, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@acs-bot
Copy link

acs-bot commented Feb 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, matt-stam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattstam mattstam deleted the matt-stam/cilium-typo branch February 11, 2021 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants