Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: deprecate kube-dashboard addon #4268

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR adds a deprecation warning whenever the kube-dashboard addon is enabled, and disables testing of this going forward.

The justification for this is that the Kubernetes version support matrix for dashboard releases is somewhat complicated, and would require an expanded aks-engine test matrix in order to reliably produce a known-working implementation across the set of supported Kubernetes versions that aks-engine can create clusters with. See:

https://github.com/kubernetes/dashboard/releases

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Feb 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Member Author

cc @mboersma @jadarsie @craiglpeters

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #4268 (a08751a) into master (6726888) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4268   +/-   ##
=======================================
  Coverage   72.02%   72.03%           
=======================================
  Files         141      141           
  Lines       21625    21627    +2     
=======================================
+ Hits        15576    15578    +2     
  Misses       5099     5099           
  Partials      950      950           
Impacted Files Coverage Δ
pkg/api/common/const.go 100.00% <ø> (ø)
pkg/api/k8s_versions.go 100.00% <ø> (ø)
pkg/engine/templates_generated.go 43.56% <ø> (ø)
pkg/api/vlabs/validate.go 81.46% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab7d91...a08751a. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm generally, but it also deletes

  • docs/topics/kubernetes-walkthrough.md
  • docs/topics/monitoring.md

which doesn't seem like a related change. Could those go in a separate PR?

@jackfrancis
Copy link
Member Author

@mboersma good idea:

#4287

(That removal was identified as a part of this particular PR spike because it recommends installing the dashboard.)

@jackfrancis jackfrancis merged commit b3aa75c into Azure:master Feb 19, 2021
@jackfrancis jackfrancis deleted the deprecate-dashboard branch February 19, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants