Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: deprecate rescheduler addon #4275

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR deprecates and removes the long-obsolete rescheduler addon. The justification for removing it entirely is that it is ~3 years out of date, and deprecated upstream as of Kubernetes v1.10.0. We want to prevent folks from installing it on new clusters as the functional outcomes from running this addon on your cluster is unknown.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #4275 (8ea891e) into master (f220f16) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4275   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files         141      141           
  Lines       21686    21665   -21     
=======================================
- Hits        15630    15616   -14     
+ Misses       5106     5099    -7     
  Partials      950      950           
Impacted Files Coverage Δ
pkg/api/addons.go 98.07% <ø> (-0.03%) ⬇️
pkg/api/common/const.go 100.00% <ø> (ø)
pkg/api/k8s_versions.go 100.00% <ø> (ø)
pkg/api/types.go 92.85% <ø> (-0.02%) ⬇️
pkg/engine/artifacts.go 98.93% <ø> (-0.03%) ⬇️
pkg/engine/templates_generated.go 43.80% <ø> (+0.38%) ⬆️
pkg/api/vlabs/validate.go 81.42% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f220f16...8ea891e. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 5c1707d into Azure:master Feb 19, 2021
@jackfrancis jackfrancis deleted the deprecate-rescheduler branch February 19, 2021 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants