Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: use AZURE_CORE_ONLY_SHOW_ERRORS when running E2E #4288

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Feb 20, 2021

Reason for Change:

This PR ensures that any usage of the E2E test runner invoked az with the suppression of non-error output.

See:

https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/HISTORY.rst#230

Also, two tweaks to the vmss-prototype tests based on observations:

  • If we're configured to test the vmss-prototype functionality, we automatically set RunUnattendedUpgradesOnBootstrap to false in the LinuxProfile
  • retry the kured daemonset creation

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Feb 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #4288 (3b57385) into master (c252387) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4288      +/-   ##
==========================================
+ Coverage   72.02%   72.03%   +0.01%     
==========================================
  Files         141      141              
  Lines       21625    21633       +8     
==========================================
+ Hits        15576    15584       +8     
  Misses       5099     5099              
  Partials      950      950              
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <0.00%> (ø)
pkg/api/vlabs/validate.go 81.46% <0.00%> (+0.03%) ⬆️
pkg/armhelpers/mockclients.go 25.05% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c252387...c308e1c. Read the comment docs.

@jackfrancis jackfrancis merged commit a9e0e3b into Azure:master Feb 20, 2021
@jackfrancis jackfrancis deleted the e2e-az-ignore-warnings branch February 20, 2021 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants