Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: Hsn fix for 2c+ #4315

Merged
merged 1 commit into from
Mar 16, 2021
Merged

chore: Hsn fix for 2c+ #4315

merged 1 commit into from
Mar 16, 2021

Conversation

jsturtevant
Copy link
Contributor

Reason for Change:

Hsn fix for 2c+

If multiple LB policies are included for same endpoint then HNS hangs. this fix forces an error so restarts to HNS are not required.

Issue Fixed:

Credit Where Due:
Azure/AgentBaker#628
/cc @AbelHu @mainred

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jsturtevant jsturtevant changed the title Hsn fix for 2c+ chore: Hsn fix for 2c+ Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #4315 (c94573d) into master (f81f85f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4315   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files         141      141           
  Lines       21634    21634           
=======================================
  Hits        15590    15590           
  Misses       5093     5093           
  Partials      951      951           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 43.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81f85f...c94573d. Read the comment docs.

AbelHu
AbelHu previously approved these changes Mar 4, 2021
AbelHu
AbelHu previously approved these changes Mar 10, 2021
# this fix forces an error
Write-Host "Enable a HNS fix in 2021-2C+"
reg add HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\hns\State /v HNSControlFlag /t REG_DWORD /d 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this ever be set by default in some future OS updates or will we always need to set this?
Is this only needed on Windows Server 2019 or all Windows Server OS versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daschott do you have insight here?

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AbelHu, jackfrancis, jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants