-
Notifications
You must be signed in to change notification settings - Fork 522
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4315 +/- ##
=======================================
Coverage 72.06% 72.06%
=======================================
Files 141 141
Lines 21634 21634
=======================================
Hits 15590 15590
Misses 5093 5093
Partials 951 951
Continue to review full report at Codecov.
|
caed3f6
to
a89fd39
Compare
# this fix forces an error | ||
Write-Host "Enable a HNS fix in 2021-2C+" | ||
reg add HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\hns\State /v HNSControlFlag /t REG_DWORD /d 1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this ever be set by default in some future OS updates or will we always need to set this?
Is this only needed on Windows Server 2019 or all Windows Server OS versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daschott do you have insight here?
f880af1
to
3294293
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AbelHu, jackfrancis, jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Hsn fix for 2c+
If multiple LB policies are included for same endpoint then HNS hangs. this fix forces an error so restarts to HNS are not required.
Issue Fixed:
Credit Where Due:
Azure/AgentBaker#628
/cc @AbelHu @mainred
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: