This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
test: fix prior k8s minor version in mocks and upgrade test #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4359 +/- ##
=======================================
Coverage 72.08% 72.08%
=======================================
Files 141 141
Lines 21662 21662
=======================================
Hits 15616 15616
Misses 5094 5094
Partials 952 952
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Some unit test code was naively calculating the prior Kubernetes version by decrementing the minor but leaving the major and patch versions intact. This will fail when Kubernetes 1.18.18 comes out next week, since it will supply "1.17.18" which doesn't and won't exist.
Instead let's reuse the
RationalizeReleaseAndVersionfunc to get the latest patch for the previous minor release correctly.Issue Fixed:
Prevents a test bug that will arise next Wednesday when v1.18.18 drops.
Credit Where Due:
Does this change contain code from or inspired by another project?
Requirements:
Notes: