fix: Fix installer for custom package URL's. #4364
Conversation
Ran into this in CI where I'm trying to test new packages. runc that's already installed in the vm image is older than the minimum version of the new package, as such the package installation fails and cluster provisioning errors out. apt has functionality to fix dependency problems found while using `dpkg`. This adds a helper function to replace `dpkg install` with one that basically calls `apt-get update && apt-get install -f` after a failed install (update is required as well, otherwise the package list is out of date).
cpuguy83
force-pushed
the
fix_dpkg_install
branch
from
a2ce3b2 to
f5ace6b
Compare
cpuguy83
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4364 +/- ##
=======================================
Coverage 72.09% 72.09%
=======================================
Files 141 141
Lines 21665 21665
=======================================
Hits 15619 15619
Misses 5094 5094
Partials 952 952
Continue to review full report at Codecov.
|
| dpkg_install() { | ||
| retries=$1; wait_sleep=$2; shift && shift; | ||
| for i in $(seq 1 $retries); do | ||
| wait_for_apt_locks; dpkg -i "${1}" && break; apt-get update --fix-missing; do_apt_get_install -f && break |
There was a problem hiding this comment.
clever usage of the -f there in the new do_apt_get_install func
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpuguy83, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Ran into this in CI where I'm trying to test new packages.
runc that's already installed in the vm image is older than the minimum
version of the new package, as such the package installation fails and
cluster provisioning errors out.
apt has functionality to fix dependency problems found while using
dpkg.This adds a helper function to replace
dpkg installwith one thatbasically calls
apt-get update && apt-get install -fafter a failedinstall (update is required as well, otherwise the package list is out
of date).
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: