Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: make e2e "singleCommandTimeout" configurable for azs #4372

Merged

Conversation

haofan-ms
Copy link
Contributor

Reason for Change:

Make "singleCommandTimeout" param in e2e configurable for AzureStack, as this is causing timeout in test failures.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@haofan-ms haofan-ms requested a review from jadarsie April 20, 2021 06:09
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #4372 (6d531fd) into master (60828c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4372   +/-   ##
=======================================
  Coverage   72.04%   72.04%           
=======================================
  Files         141      141           
  Lines       21631    21631           
=======================================
  Hits        15584    15584           
  Misses       5096     5096           
  Partials      951      951           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 43.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d05cdf...6d531fd. Read the comment docs.

@jadarsie
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Apr 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haofan-ms, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jadarsie jadarsie merged commit 3d8a38f into Azure:master Apr 20, 2021
@haofan-ms haofan-ms deleted the configurable-singleCommandTimeout-for-azs branch February 16, 2022 04:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants