-
Notifications
You must be signed in to change notification settings - Fork 519
Conversation
cc @jadarsie @haofan-ms @Michael-Sinz Note that this PR doesn't actually deprecate Ubuntu 16.04-LTS. Its intention is to make it much less likely that someone would build a new cluster backed by 16.04-LTS (the default has been 18.04-LTS for a long time, so any new 16.04-LTS clusters would have to be explicitly configured as such). |
Codecov Report
@@ Coverage Diff @@
## master #4418 +/- ##
========================================
Coverage 72.04% 72.05%
========================================
Files 141 141
Lines 21631 21764 +133
========================================
+ Hits 15584 15681 +97
- Misses 5096 5131 +35
- Partials 951 952 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see things removed, especially those EOL 16.04 references.
@@ -15,7 +15,7 @@ | |||
}, | |||
"masterProfile": { | |||
"dnsPrefix": "", | |||
"distro": "ubuntu", | |||
"distro": "ubuntu-18.04", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue to move these out of az/akse #4423
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, jadarsie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
This PR updates documentation to remove recommended references to the "ubuntu" and "aks-ubuntu-16.04" distro values, as we want to discourage new usages of Ubuntu 16.04-LTS, which as reached EOL.
Additionally, we will now log a warning message when a new cluster is built with a 16.04-LTS configuration.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: