test: use kured 1.7.0 to validate kamino #4427
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4427 +/- ##
========================================
Coverage 72.04% 72.05%
========================================
Files 141 141
Lines 21631 21764 +133
========================================
+ Hits 15584 15681 +97
- Misses 5096 5131 +35
- Partials 951 952 +1
Continue to review full report at Codecov.
|
| cmd := exec.Command("helm", "install", "--wait", "--generate-name", "--repo", "https://weaveworks.github.io/kured", "kured", "--version", "1.7.0", "--set", "configuration.annotateNodes=true", "--set", "configuration.period=1m") | ||
| util.PrintCommand(cmd) | ||
| out, err := cmd.CombinedOutput() | ||
| log.Printf("%s\n", out) |
There was a problem hiding this comment.
Now that this does the annotations, we could run vmss-prototype with the automatic mode where it uses the annotations. That would help validate that too and simplify some of the logic here.
Also, kamino no longer deletes the "prototype" node, it just reboots it (temporary shutdown in order to take the snapshot).
You just need to tell kamino what annotations to look for via kamino.auto.lastPatchAnnotation and, more importantly, kamino.auto.pendingRebootAnnotation.
These values tell the names of the the annotations within the node. I think you want:
kamino.auto.lastPatchAnnotation=weave.works/kured-most-recent-reboot-needed
kamino.auto.pendingRebootAnnotation=weave.works/kured-reboot-in-progress
There is also the cronjob mechanism but you don't want that as you want to signal directly.
There was a problem hiding this comment.
Oops, I did not scroll down far enough in the unchaged code - you already do that. :-)
There was a problem hiding this comment.
Definitely. I wanted to quickly get rid of my static manifest referencing my custom-built kured image first.
Next step will be to integrate this test scenario into a "soak" cluster so that we can validate the nominal use case of vmss prototype being a "self-maintaining" VMSS optimization.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, Michael-Sinz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
This PR uses the kured 1.7.0 chart now that 1.7.0 has been released w/ node annotations support. See:
https://github.com/weaveworks/kured/releases/tag/1.7.0
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: