This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: Add Dockerfile for convenient building #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables cases like `docker build --output=bin/ https://github.com/Azure/aks-engine.git` without having to manually check out code and everything. It supports cross compilation so a user can set `--platform=darwin/amd64` or `--platform=local`, etc. to get a binary for whatever they need.
Codecov Report
@@ Coverage Diff @@
## master #4431 +/- ##
========================================
Coverage 72.04% 72.05%
========================================
Files 141 141
Lines 21631 21764 +133
========================================
+ Hits 15584 15681 +97
- Misses 5096 5131 +35
- Partials 951 952 +1
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpuguy83, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
pushed a commit
that referenced
this pull request
May 25, 2021
This enables cases like `docker build --output=bin/ https://github.com/Azure/aks-engine.git` without having to manually check out code and everything. It supports cross compilation so a user can set `--platform=darwin/amd64` or `--platform=local`, etc. to get a binary for whatever they need.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This enables cases like
docker build --output=bin/ https://github.com/Azure/aks-engine.gitwithout having to manuallycheck out code and everything.
It supports cross compilation so a user can set
--platform=darwin/amd64or--platform=local, etc. to get a binaryfor whatever they need.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: